[Octave-bug-tracker] [bug #55161] Cannot open multiple files from Google Drive File Stream in the editor

[Markus Mützel]

Follow-up Comment #21, bug #55161 (project octave):

canonicalize_file_name doesn't necessarily give the same result on Windows
when it comes to case sensitivity and short paths (8.3 names). Additionally,
it doesn't work for UNC paths IIRC. (I came across this in bug #56267.)
There is an initial patch for the former issues in bug #56267.

Maybe a work-around would be to check whether the path started with "\\" and
use the current code path. And call (a fixed) canonicalize_file_name otherwise
before comparing.
But that would introduce an additional code path we need to maintain.

Long story short: I think the best solution atm would probably be to fix
same_file_internal with the additional comparisons as Kai suggested.
The reason why we have Windows specific code there in the first place is
non-ASCII characters and the Windows file API needs special handling (even
gnulib's fstat replacement doesn't work).

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55161>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/