[Octave-bug-tracker] [bug #56805] Using unrecognized char in text results in infinite warning loop

[Markus Mützel]

Follow-up Comment #8, bug #56805 (project octave):

@Rik: You are right. I didn't read the sources before commenting.

The two attached patches fix the orientation of the output vector of
native2unicode and remove the duplicate input checks from the internal
functions.

AKAIK, Matlab uses only the BMP of UTF-16 (i.e. UCS-2). So there is probably
no example where a single character in any encoding would lead to a two
element result of native2unicode in Matlab.
We decided we want to use UTF-8 instead. If I remember correctly the reasoning
was that most third party libraries are using 8bit chars as their strings.
Thus, if our strings are of 8bit chars as well we would need to convert them
at less interfaces.

This still leaves the original issue.

(file #47443, file #47444)
    _______________________________________________________

Additional Item Attachment:

File name: bug56805_native2unicode_row_vector.patch Size:0 KB
   
<https://savannah.gnu.org/file/bug56805_native2unicode_row_vector.patch?file_id=47443>

File name: bug56805_native2unicode_input_checks.patch Size:1 KB
   
<https://savannah.gnu.org/file/bug56805_native2unicode_input_checks.patch?file_id=47444>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?56805>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/