[Octave-bug-tracker] [bug #35910] Incorrect regex matching of multi-byte UTF-8 characters

[Rik]

Follow-up Comment #10, bug #35910 (project octave):

I think we need to put in a compile-time test.  The question is, should we
make it optional or not?  The existing test for PCRE in configure.ac is


### Check for PCRE regex library.

OCTAVE_CHECK_LIB(pcre, PCRE,
  [], [pcre.h pcre/pcre.h], [pcre_compile], [], [], [],
  [libpcre], [REQUIRED])


The addition of the "REQUIRED" field to the OCTAVE_CHECK_LIB macro means that
the entire configure process will abort if PCRE is not available.  PCRE is a
*hard* requirement.  So, the question is, should we require a UTF8 enabled
PCRE as a hard requirement or not.

As Mike says, I bet most distributions have been compiling with UTF8 support
for a long time now.  So for the vast majority of users this won't be an
issue.  For those who compile their own PCRE, we can either inconvenience them
by requiring that they re-compile their home-built library with UTF8 enabled,
or we can inconvenience our lives by having a UTF8 check in configure and then
adding #ifdef's around various pieces of code in our own codebase.

Right now, I guess I'm feeling selfish and would require others to modify
their compile options.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?35910>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/