[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #56560] [octave forge] (control) Error by addi

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #56560] [octave forge] (control) Error by addition of two frd objects
Date: Wed, 3 Jul 2019 19:04:45 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Update of bug #56560 (project octave):

                  Status:                    None => Patch Submitted        


Follow-up Comment #13:

With the changes in comment #7, the original bug reported here looks fixed to
me. Here is a patch repeating those changes with Octave coding style

diff --git a/inst/@frd/__sys_group__.m b/inst/@frd/__sys_group__.m
--- a/inst/@frd/__sys_group__.m
+++ b/inst/@frd/__sys_group__.m
@@ -28,10 +28,12 @@ function retsys = __sys_group__ (sys1, s
   if (! isa (sys1, "frd"))
     sys1 = frd (sys1, sys2.w);
+    sys1.lti = sys2.lti;
   if (! isa (sys2, "frd"))
     sys2 = frd (sys2, sys1.w);
+    sys2.lti = sys1.lti;
   retsys = frd ();

So I'd call that a fix and close this. Both for the original example and the
full example in comment #11.

There is still another issue with the full script in the call to "bode" on a
system of type "frd", but that shouldn't block this bug from being fixed.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]