[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #55727] Feature request: add GEJSV as an addit
[Octave-bug-tracker] [bug #55727] Feature request: add GEJSV as an additional svd_drivers
Tue, 19 Mar 2019 13:11:58 -0400 (EDT)
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Follow-up Comment #4, bug #55727 (project octave):
Update to the patch of the GEJSV driver (replace previous one), see attachment
Fixed few bugs in previous patch: about size of singular vector under some
condition, and about the test case of GEJSV. Also it is now follow the C++
style guide <https://wiki.octave.org/C%2B%2B_style_guide> tightly.
Now the patch is been tested for all combination of: different matrix sizes
(tall, square, fat) with different number of output arguments, different data
types (single, double, complex single, complex double) and full SVD v.s.
economy SVD. Tested against --enable-address-sanitizer-flags.
Personally, I have used it for a while, so I think it is mature enough now.
To be more clear about what is inside, the changeset is consist of:
lines-of-code What for
202 declare FORTRAN functions
136 C++ interface to FORTRAN utilizer functions
129 compute optimal work space size for GEJSV
132 C++ interface to GEJSV
88 svd C++ class
rest Fsvd () and documents.
The test script is also uploaded for convenient. Just run
(file #46580, file #46581, file #46582)
Additional Item Attachment:
File name: bug55727_gejsv_v2.patch Size:36 KB
File name: test_gejsv_all_cases.m Size:2 KB
File name: svd_std_self_test.m Size:1 KB
Reply to this item at:
Message sent via Savannah
|[Prev in Thread]
||[Next in Thread]|
- [Octave-bug-tracker] [bug #55727] Feature request: add GEJSV as an additional svd_drivers,