[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55895] __go_patch__ fails when NaN vertices e

From: Eddy
Subject: [Octave-bug-tracker] [bug #55895] __go_patch__ fails when NaN vertices exist
Date: Sun, 17 Mar 2019 07:18:21 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Follow-up Comment #6, bug #55895 (project octave):

They are different bugs, but related because of the variable
`coplanar_last_idx`. Coplanar tester is the writer,
`opengl_renderer::draw_patch` is the reader. The decision to not include
unclosed patch in coplanar_last_idx will affect both sides.

I put the fix to both bugs in one patch (see attached file), otherwise the
patches will depends on each other to work correctly. I also moved the
coplanar test&partition code into a new function, because I think it is
complex enough and independent enough.

I tested the samples in comment #4, comment #3, comment #0, comment #0 in bug
#55751 <https://savannah.gnu.org/bugs/?55751#comment0> and a patch demo
No problem so far.

make check failed at bsxfun.cc-tst, so I can't run a full test.

(file #46562)

Additional Item Attachment:

File name: bug55895_allow_nan_v2.patch    Size:9 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]