[Octave-bug-tracker] [bug #55902] Reformat libqterminal's ExtendedDefaultTranslator*.h for consistency

[Andrew Janke]

Follow-up Comment #2, bug #55902 (project octave):

I think they are being used, at least on Mac.

I added this to ExtendedDefaultTranslatorMac.h:


"key Left +Control : \"Control-Left\"\n"
"key Left +Meta : \"Meta-Left\"\n"
"key Left +Shift : \"Shift-Left\"\n"


and banged on the keyboard a bit, and this came out:


>> Control-Left Meta-Left Shift-Left


Which means I'll need to edit this file in order to fix
https://savannah.gnu.org/bugs/index.php?49703#comment9, so it'd be nice if
this could be merged to make editing easier.

Additionally, I stuck some debugging code in:


const KeyboardTranslator* KeyboardTranslatorManager::findTranslator(const
QString& name)
{
    if ( name.isEmpty() ) {
        printf("%s\n", "Using default translator because name is empty.");
        return defaultTranslator();
    }

    //here was smth wrong in original Konsole source
    findTranslators();

    if ( _translators.contains(name) && _translators[name] != nullptr ) {
        qDebug() << "Found cached keyboard translator name=" << name;
        return _translators[name];
    }

    KeyboardTranslator* translator = loadTranslator(name);

    if ( translator != nullptr ) {
        qDebug() << "Loaded keyboard translator name=" << name;
        _translators[name] = translator;
    }
    else if ( !name.isEmpty() )
        qWarning() << "Unable to load translator" << name;

    return translator;
}


And got this when I ran octave-gui:


$ ./run-octave --gui
Using default translator because name is empty.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55902>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/