[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55902] Reformat libqterminal's ExtendedDefaul

From: Andrew Janke
Subject: [Octave-bug-tracker] [bug #55902] Reformat libqterminal's ExtendedDefaultTranslator*.h for consistency
Date: Wed, 13 Mar 2019 17:42:29 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.75 Safari/537.36

Follow-up Comment #2, bug #55902 (project octave):

I think they are being used, at least on Mac.

I added this to ExtendedDefaultTranslatorMac.h:

"key Left +Control : \"Control-Left\"\n"
"key Left +Meta : \"Meta-Left\"\n"
"key Left +Shift : \"Shift-Left\"\n"

and banged on the keyboard a bit, and this came out:

>> Control-Left Meta-Left Shift-Left

Which means I'll need to edit this file in order to fix
https://savannah.gnu.org/bugs/index.php?49703#comment9, so it'd be nice if
this could be merged to make editing easier.

Additionally, I stuck some debugging code in:

const KeyboardTranslator* KeyboardTranslatorManager::findTranslator(const
QString& name)
    if ( name.isEmpty() ) {
        printf("%s\n", "Using default translator because name is empty.");
        return defaultTranslator();

    //here was smth wrong in original Konsole source

    if ( _translators.contains(name) && _translators[name] != nullptr ) {
        qDebug() << "Found cached keyboard translator name=" << name;
        return _translators[name];

    KeyboardTranslator* translator = loadTranslator(name);

    if ( translator != nullptr ) {
        qDebug() << "Loaded keyboard translator name=" << name;
        _translators[name] = translator;
    else if ( !name.isEmpty() )
        qWarning() << "Unable to load translator" << name;

    return translator;

And got this when I ran octave-gui:

$ ./run-octave --gui
Using default translator because name is empty.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]