octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #55888] running rmdir() in unsaved script in G


From: Mike Miller
Subject: [Octave-bug-tracker] [bug #55888] running rmdir() in unsaved script in GUI editor causes tab to be closed or saved
Date: Tue, 12 Mar 2019 15:29:12 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Safari/537.36

Follow-up Comment #1, bug #55888 (project octave):

This bug happens because the 'file_editor_tab::file_has_changed' slot is being
called even when the editor tab does not have a file name. The '_file_name'
member variable is an empty string, 'file_exists' is false, and
'_edit_area->isModified ()' returns true.

There's a lot going on in that slot, but is the purpose of that function only
to handle the case when a file on disk is modified outside of the Octave
editor? If so, then should that slot simply return immediately if '_file_name'
is empty and just leave things alone? Or will that break some other case, like
exiting Octave or closing the tab?

Cc'ing Torsten.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55888>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]