[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modifi

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modification to include all 4 FIR types, Hilbert transformer, and differentiator
Date: Sat, 9 Mar 2019 15:11:57 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Safari/537.36

Follow-up Comment #18, bug #51310 (project octave):

Thank you, I will take a look at this latest revision in the next week.

I sincerely appreciate all the work you have put into this function

I understand and appreciate the learning curve when submitting changes,
especially when there are code style guidelines and conventions that you may
not be familiar with. We try to document these things for new contributors,
but we could use some help improving that. There's no need to apologize, our
community should do a better job of documenting and supporting new

If you are talking about other functions in the signal package, yes, many of
these files are 10 or 20 years old now, from before a lot of the Octave coding
guidelines have been applied. As a background task I have been working to make
these older functions conform to the current coding guidelines, but it's a
slow process. If you are looking for functions to compare with, it's far
better to look at Octave itself, not the signal package, as a standard.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]