[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modifi

From: Vlad
Subject: [Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modification to include all 4 FIR types, Hilbert transformer, and differentiator
Date: Fri, 8 Mar 2019 04:39:20 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Firefox/60.0

Follow-up Comment #17, bug #51310 (project octave):

My apologies for the bad formatting, some of these I only hear about them for
the first time:

- used "@end example" and "@end deftypefn" where needed
- used "@cite" in the reference section (used as it is in ellipord.m, the only
one that has this in the signal package)
- the changelog is moved outside the doc part (for example FIXME in fir1.m)
- added a @seealso
- corrected differences between "@var{x}" and 'x'
- added "firls: " as a prefix to all printed messages
- used warning() instead of sprintf()
- reformatted the error messages
- relaxed tolerances for the test suite to account for differences between
wxMaxima's fpprec>16 and bfloat(), and Octave's
- corrected single quotes to double quotes in string arguments

The errors were less than 1e-15 when I tested them, but that was with another
implementation of expint.m, but it's not just that script, it's cumulative,
within double precision error. If all these were said in the beginning, they
would have been corrected right then (save my mistakes). IMO, that would have
been easier than force the users to dig in the whole lot of scripts, trying to
hunt down and concoct their own rules of formatting based on what they see,
because, and I hope you do know this, too many are not at all as you had me
make this, and some even differ between themselves in the same categories.

(file #46464)

Additional Item Attachment:

File name: firls.m                        Size:40 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]