[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modifi

From: Mike Miller
Subject: [Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modification to include all 4 FIR types, Hilbert transformer, and differentiator
Date: Tue, 5 Mar 2019 18:11:50 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.119 Safari/537.36

Follow-up Comment #14, bug #51310 (project octave):

Let's try to avoid debating bug tracker categorization details, ok?

I reviewed a batch of open signal package bugs to determine which ones can be
done for the next version, and I am planning on finishing this bug, hopefully
with your help.

In the process I briefly looked at the latest revision attached here, and I
see some things that still need fixing. I see that you have this on GitHub,
would it be easier to discuss and iterate there? I find a platform like GitLab
or GitHub much easier to work with than Savannah when reviewing and making
line-by-line comments.

I would appreciate it if you were open to dropping the 'MatlabCompat' flag
entirely (reducing it to 'true' by default). If you are not, I respect your
point of view, but honestly I will probably remove it and the associated
complicated logic when incorporating this function into the signal package.

To be clear, that is not the reason for this taking so long and not being done
yet, there are other issues with the doc string, the error reporting, unit
test failures, all of which I would like to fix or see fixed with your help
before this is committed.

Are you still willing to help get this ready for incorporating into the
package? Here or on GitHub? If GitHub please push the latest changes you
shared here as file #43795.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]