|
From: | Rik |
Subject: | [Octave-bug-tracker] [bug #43098] "if (array)" should raise a warning, and give the same result for dense and sparse |
Date: | Wed, 29 Jun 2016 17:25:19 +0000 (UTC) |
User-agent: | Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 |
Update of bug #43098 (project octave): Status: Patch Submitted => Fixed Open/Closed: Open => Closed _______________________________________________________ Follow-up Comment #15: @Lachlan: Okay, I applied your cset here (http://hg.savannah.gnu.org/hgweb/octave/rev/efce657ceb86). I made a few changes, see the attached if_array.diff file. It was small stuff, in one case the C++ function had a return prototype of bool but you were returning 0. It seemed clearer to use false in this case. Also, do you have the username variable set in your .hgrc? The last two HG csets from you have not had the committer information, and I certainly want to give credit where it is due. (file #37625) _______________________________________________________ Additional Item Attachment: File name: if_array.diff Size:4 KB _______________________________________________________ Reply to this item at: <http://savannah.gnu.org/bugs/?43098> _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/
[Prev in Thread] | Current Thread | [Next in Thread] |