[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #48243] Fix statistics computation in ode45 an
From: |
Rik |
Subject: |
[Octave-bug-tracker] [bug #48243] Fix statistics computation in ode45 and ode23 |
Date: |
Mon, 20 Jun 2016 16:04:59 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 |
Update of bug #48243 (project octave):
Status: None => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #1:
@Jacopo: I modified your patch for ode statistics slightly and pushed it here
(http://hg.savannah.gnu.org/hgweb/octave/rev/0f3e875d9078).
There was a semicolon missing which led to one of the statistics variable
being printed. My habit is to apply a patch and then run the BIST tests with,
for example, 'test ode23' to make sure nothing was broken. That's how I
caught the semicolon.
Also, for the commit message, we like to reference the bug number in the
commit message. This makes it very easy to find which patch was used to fix a
particular bug if things go wrong.
hg log -k 'bug #XXXXX'
One last thing, you modified private/integrate_adaptive.m. There are two
other functions, integrate_n_steps.m and integrate_const.m, in that directory.
Do they require fixing as well?
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?48243>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/