Bug#971441: Package not built from source: gengetopt

[Ian Jackson]

Source: oath-toolkit
Version: 2.6.1-1.4
Severity: important

The program oathtool uses gengetopt.  A .ggo file is provided.
But in the actual package build, this is not necessariloy used,
because the upstream source contains the gengetopt output.

In my test, the attached patch fixed this.  I found that the package
still built, so I am tagging this bug as "important" (because it could
mask a future FTBFS) rather than "serious".

Thanks,
Ian.

diff --git a/debian/control b/debian/control
index 32fbc3d..33e290f 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: devel
 Priority: optional
 Maintainer: OATH Toolkit Team <oath-toolkit-help@nongnu.org>
 Uploaders: Simon Josefsson <simon@josefsson.org>
-Build-Depends: cdbs, debhelper (>= 7.0.0), libpam0g-dev, datefudge, 
gtk-doc-tools, dblatex, libxml2-utils, libxmlsec1-dev, dh-autoreconf
+Build-Depends: cdbs, debhelper (>= 7.0.0), libpam0g-dev, datefudge, 
gtk-doc-tools, dblatex, libxml2-utils, libxmlsec1-dev, dh-autoreconf, gengetopt
 Standards-Version: 3.9.6
 Homepage: http://www.nongnu.org/oath-toolkit/
 Vcs-Browser: https://salsa.debian.org/debian/oath-toolkit
diff --git a/debian/rules b/debian/rules
index 039d31e..22c0f52 100755
--- a/debian/rules
+++ b/debian/rules
@@ -10,3 +10,7 @@ DEB_DH_MAKESHLIBS_ARGS_liboath0 = -- -c4
 DEB_CONFIGURE_EXTRA_FLAGS = --enable-gtk-doc --enable-gtk-doc-pdf 
 DEB_CONFIGURE_EXTRA_FLAGS += --with-pam-dir=/lib/security
 DEB_CONFIGURE_EXTRA_FLAGS += --disable-pskc
+
+pre-build::
+       @# we want to rebuild these from source
+       rm -f oathtool_cmd.h oathtool_cmd.c:


-- 
Ian Jackson <ijackson@chiark.greenend.org.uk>   These opinions are my own.  

Pronouns: they/he.  If I emailed you from @fyvzl.net or @evade.org.uk,
that is a private address which bypasses my fierce spamfilter.