nmh-workers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Misplaced header include in some files for sbr/globals.h?


From: Andy Bradford
Subject: Misplaced header include in some files for sbr/globals.h?
Date: 10 Nov 2022 21:29:17 -0700

Hello,

While compiling on OpenBSD I encountered some failures due the placement
of this line:

#include "sbr/globals.h"

For some reason  it's nested in an  #ifdef block, and I  think it should
actually be outside of the block. For example:

https://git.savannah.nongnu.org/cgit/nmh.git/commit/uip/rcvtty.c?id=472d87ae1864d7486a8d2d241eb2d82481a27c16

Why shouldn't the include be above with all the rest of the includes? As
it is,  I compilation fails  due to "undeclared identifier"  errors such
as:

uip/rcvtty.c:96:31: error: use of undeclared identifier 'invo_name'
    arguments = getarguments (invo_name, argc, argv, 1);

Is there a reason why the include is nested in the #ifdef?

Thanks,

Andy




reply via email to

[Prev in Thread] Current Thread [Next in Thread]