On Mon, Dec 26, 2011 at 20:19,
<address@hidden> wrote:
On Mon, 26 Dec 2011 14:35:18 PST, Lyndon Nerenberg said:
> > sbr/discard.c contains a rather evil piece of code that gropes around inside of stdio's FILE struct.
>
> Also, m_getfld.c contains similar poltergeist activities.
"-EGADS - violates the principle of least surprise" -- Casey Schaufler
The 'ifdef LINUX_STDIO' in discard.c can probably die, as we seem to have an
fpurge() function in glibc since 2.1.95. Anybody still running a glibc older
than that deserves to not have nice things.
Not sure what m_getfld.c is doing there. Something underhanded, I suspect.
If I remember right, m_getfld.c tries to eek the most performance out of header field scanning by taking advantage of knowledge of the stdio structures to peek further into the buffer and do an optimized ungetc().
That was necessary in the days when a VAX was fast. But these days my cell phone is faster than a room full of VAXen and we could re-write the code to be more readable and no-one would know the difference.
_______________________________________________
Nmh-workers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/nmh-workers