[Netutils-dev] ping/ping6 merging common code and segfault patch

[Rakesh Pandit]

Hello,

I have incorporated all changes recommended last month( in
bug-inetutils ML). These include:

1. Correct ChangeLog

2008-10-06  Rakesh Pandit  <address@hidden>

        * ping/libping.c, ping/ping_common.c, ping/ping_common.h
        (ping_set_count, ping_set_sockopt, ping_set_interval):
        Moved functions from libping.c to ping_common.c and made
        corresponding entries in ping_common.h

        * ping/ping6.c (main): Used ping_set_interval, ping_set_sockopt,
        ping_set_count in place of directly modifying struct p.

2008-10-06  Rakesh Pandit  <address@hidden>

        * ping/ping_common.h, ping/ping.c, ping/ping_address.c,
        ping/ping_echo.c, ping/ping_router.c, ping/ping_timestamp.c,
        ping/libping.c: Added common headers from ping related
        files (ping.c, ping_address.c, ping_echo.c, ping_router.c,
        ping_timestamp.c, libping.c) and ping6.c to ping/ping_common.h.

        * ping/ping.h, ping/ping6.h, ping/ping_common.h (ping_data,
        ping_efp): Moved ping_data, ping_efp from ping.h & ping6.h
        to ping_common.h

        * ping/libping.c, ping/ping6.c, ping/ping_common.c (_ping_setbuf,
        ping_set_data): Moved _ping_setbuf and ping_set_data from libping.c
        & ping6.c to ping_common.c

        * ping/ping_common.h (ping_address, event, ping_data): Introduced new
        unions ping_address and event in ping_common.h. Replaced ping efp
        handler(ping_efp/ping_efp6) with event union and socket 
address(sockaddr_in/
        sockaddr_in6) with ping_address union.

        * ping/ping_common.h (_PING_BUFLEN, _ping_setbuf, ping_set_data): New 
arg
        use_ipv6 and all callers changed.
        
2008-10-06  Rakesh Pandit  <address@hidden>

        * libicmp/Makefile.am (libicmp_a_SOURCES): Removed libping.c
        and ping.h

        * ping/Makefile.am (ping_SOURCES): Added libping.c and ping.h

2008-10-06  Rakesh Pandit  <address@hidden>

        * ping/ping6.c (is_root, count, interval, socket_type):
        New global variables count, interval & socket_type, similar to ping.c
        Initialize to is_root and count to false and DEFAULT_PING_COUNT
        respectively.

        * ping/ping6.c (parse_opt): Replaced ping structure usage with global
        variables.

        * ping/ping6.c (main): Assigned parsed values to ping structure.

2. Use of USE_IPV6 in place of IS_PING6

3. Use of ping_sockaddr in place of address

Attached are all four patches in a common git diff + new files moved
into ping folder from libicmp
(as these files did not came in diff)

For each separate patch refer to:
1. http://lists.gnu.org/archive/html/bug-inetutils/2008-08/msg00052.html
2. http://lists.gnu.org/archive/html/bug-inetutils/2008-08/msg00057.html
3. http://lists.gnu.org/archive/html/bug-inetutils/2008-08/msg00058.html
4. http://lists.gnu.org/archive/html/bug-inetutils/2008-08/msg00060.html

Cheers,

--
rakesh

ping_ping6_patch.diff
Description: Text Data

ping.h
Description: Text Data

libping.c
Description: Text Data