Re: [PATCH] syntax: gentoo: some cleaning and modernizing

[David Michael]

On Thu, Jun 24, 2021 at 5:35 AM Benno Schulenberg <bensberg@telfort.nl> wrote:
> Op 23-06-2021 om 15:13 schreef David Michael:
> > EAPI 5 is deprecated but still supported in Gentoo.  New packages
> > should not be using it, so that stuff could be dropped if you want to
> > be proactive, but then some existing packages will be missing those
> > keywords.
>
> "dohard" and "dosed" were banned in EAPI 4 already, so I've removed those.
> I've left "einstall", as it's been banned only since EAPI 6.
>
> > Sorry, I noticed that the eqmake4 function is now just an error
> > message, so that could be dropped and replaced with eqmake5.
>
> Changed.
>
> Now I notice that several keywords with "games" in their names get 
> highlighted,
> but I can't find the word "games" anywhere in the specs for EAPI 5, 6, 7 or 8.
> Are these obsolete keywords too?

It looks like the games functions were just removed last month, so
yes, they could be dropped.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ef4ea899b2fbdf66a46e2002ba8fd9be5ba1529

> Also, "dojar" and "dopython" get highlighted, but I don't see them in the 
> specs
> either.  Obsolete too?

They seem to have been builtins long ago that were replaced by other
methods, so they can be dropped.  Note that some of the other
highlighted install functions (dopam, domenu, etc.) will not be found
in the spec either, but they are defined in eclasses.

https://github.com/gentoo/gentoo/tree/master/eclass

> The keyword "newheader" is in the specs but does not get highlighted.  Should
> it be?

Sure, since doheader is hightlighted, newheader should probably get
the same treatment.

Thanks.

David