[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Nano-devel] [PATCH 1/2] display: replace the "$" continuation character
From: |
Benno Schulenberg |
Subject: |
[Nano-devel] [PATCH 1/2] display: replace the "$" continuation character with ">" and "<" |
Date: |
Thu, 7 Feb 2019 20:48:51 +0100 |
The angular brackets look a bit like arrows and thus hint much more
at the idea of continuation than a dollar sign.
Also, to avoid using the angular brackets for two purposes, the left
half of a split double-width character is shown as "[" instead of ">",
and the right half as "]" instead of "<".
This addresses https://savannah.gnu.org/bugs/?55657.
Reported-by: David Lawrence Ramsey <address@hidden>
---
src/winio.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/winio.c b/src/winio.c
index f4f20876..8bb565c0 100644
--- a/src/winio.c
+++ b/src/winio.c
@@ -1903,8 +1903,8 @@ char *display_string(const char *buf, size_t column,
size_t span, bool isdata)
column++;
}
- /* Display the right half of a two-column character as
'<'. */
- converted[index++] = '<';
+ /* Display the right half of a two-column character as
']'. */
+ converted[index++] = ']';
column++;
buf += parse_mbchar(buf, NULL, NULL);
}
@@ -1992,9 +1992,9 @@ char *display_string(const char *buf, size_t column,
size_t span, bool isdata)
index = move_mbleft(converted, index);
#ifdef ENABLE_UTF8
- /* Display the left half of a two-column character as '>'. */
+ /* Display the left half of a two-column character as '['. */
if (mbwidth(converted + index) == 2)
- converted[index++] = '>';
+ converted[index++] = '[';
#endif
}
@@ -2776,9 +2776,9 @@ int update_line(filestruct *fileptr, size_t index)
free(converted);
if (from_col > 0)
- mvwaddch(edit, row, margin, '$');
+ mvwaddch(edit, row, margin, '<');
if (strlenpt(fileptr->data) > from_col + editwincols)
- mvwaddch(edit, row, COLS - 1, '$');
+ mvwaddch(edit, row, COLS - 1, '>');
if (spotlighted && !inhelp)
spotlight(light_from_col, light_to_col);
--
2.20.1
Re: [Nano-devel] [PATCH 1/2] display: replace the "$" continuation character with ">" and "<", Benno Schulenberg, 2019/02/11