[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH V8] Implement bookmarks

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH V8] Implement bookmarks
Date: Thu, 6 Dec 2018 20:40:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Op 06-12-18 om 17:17 schreef Marco Diego Aurélio Mesquita:
>  doc/nano.texi |  9 +++++++++
>  doc/nanorc.5  |  9 +++++++++

Please move the documentation changes to a separate, third patch.
They are not an essential part of making the functions work.

> +     const char *bookmark_gist = N_("Toggle bookmark");
> +     const char *nextbookmark_gist = N_("Next bookmark");
> +     const char *prevbookmark_gist = N_("Previous bookmark");

Tags (lower down) should be very short and are okay.  But the descriptions
("gists") for the help text can be (and should be) a bit more verbose.
You have some sixty characters for each of them.  So I would suggest:

"Set or remove a bookmark on the current line"
"Go to next bookmark"
"Go to previous bookmark"

(I don't want to use the word "toggle", reserving it for the feature toggles.)

Also, nano always orders the backward function first, everywhere.

> +     else if (!strcasecmp(input, "bookmark"))
> +             s->func = bookmark;
> +     else if (!strcasecmp(input, "bookmarknext"))
> +             s->func = bookmark_next;
> +     else if (!strcasecmp(input, "bookmarkprevious"))

All other bindable functions with "prev" and "next" in their names
begin with those words instead of appending them.  So the "nextbookmark"
and "prevbookmark" should do the same.

> +void bookmark_next(void);
> +void bookmark_previous(void);


> +                                                     if (seq[3] == '3')
> +                                                             /* Esc [ 2 ; 3 
> ~ == Shift-Delete on xterm. */
> +                                                             return 

The comment does not match the code.  Also, I think the returned symbol is
commentary enough.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]