[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH V6] Implement bookmarks

From: Brand Huntsman
Subject: Re: [Nano-devel] [PATCH V6] Implement bookmarks
Date: Wed, 5 Dec 2018 15:15:30 -0700

On Tue, 4 Dec 2018 13:55:57 -0200
Marco Diego Aurélio Mesquita <address@hidden> wrote:

> Differences from V5:
>  - It is now possible to move a bookmark on the
>    current line.
>  - Next and previous no longer ignores bookmarks
>    on the current line.
>  - Added features are rebindable.

I haven't tested the patch yet but changing bookmark_x to a bool and only 
jumping to start of line, as Benno suggested, would solve the need to not 
ignore current line or move a bookmark. Less useful for softwrapped paragraphs 
but it eliminates all confusion.

go_to_book_mark() and is_bookmarked() should be static, but changing bookmark_x 
to a bool would eliminate the need to have is_bookmarked().

You need doc/nano.texi and doc/nanorc.5 documentation for the bindable function 
names in first patch. And the second patch needs to mention the hard binds in 
those two files as well. Find "zap" for an example.

A user-defined bind wouldn't show up in help without the second patch. So the 
add_to_funcs and gists should be in the first patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]