nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH 1/2] display: let the title bar show when nano i


From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH 1/2] display: let the title bar show when nano is in linting mode
Date: Mon, 22 Oct 2018 20:56:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

Op 21-10-18 om 23:05 schreef Brand Huntsman:
> The default selected and statusbar colors are identical, both use reverse 
> video. By changing to selected color, you admit your colors are not default, 
> and you are choosing the best of *your* color choices to use for linting.

No.  I change from statuscolor to selectedcolor because I want to be able to
make the linter messages a different color than the normal status-bar messages,
because they are somehow special.  They are not just messages, but they refer
to stuff where the cursor is.  And since in linting mode no text can be marked,
selectedcolor is a "free color".  Most likely it is different from titlecolor
and statuscolor and errorcolor, so it will make the linter messages stand out,
it will alert the user that this is a different mode.

> You are taking something that currently works and breaking it

How is it broken?

If you would say that if someone has chosen selectedcolor to be the same
as errorcolor, then to them the linter messages will look like errors,
then you would have a point.  But that disadvantage I'll accept.

> No one will notice if linter color continues to be statusbar color, but many 
> will if you change it to selected color.

But that is the whole point.  I want them to notice.

> You should get at least one person to agree with you before making this 
> change. Silence is not acceptance.

Oof.  If I were only allowed to make changes when someone has agreed, I
would never have accepted maintainership of nano.

Benno

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]