|
| From: | Pranav Joglekar |
| Subject: | Re: [Nano-devel] Nano-devel Digest, Vol 175, Issue 26 |
| Date: | Tue, 25 Sep 2018 08:50:43 +0530 |
Send Nano-devel mailing list submissions to
address@hidden
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.gnu.org/mailman/listinfo/nano-devel
or, via email, send a message with subject or body 'help' to
address@hidden
You can reach the person managing the list at
address@hidden
When replying, please edit your Subject line so it is more specific
than "Re: Contents of Nano-devel digest..."
Today's Topics:
1. Help Getting Started (Pranav Joglekar)
2. Re: Help Getting Started (Benno Schulenberg)
3. Re: Help Getting Started (Brand Huntsman)
4. Re: Help Getting Started (Benno Schulenberg)
5. [PATCH] bindings: make the linter separately accessible,
through M-B by default (Benno Schulenberg)
----------------------------------------------------------------------
Message: 1
Date: Sun, 23 Sep 2018 11:13:16 +0530
From: Pranav Joglekar <address@hidden>
To: address@hidden
Subject: [Nano-devel] Help Getting Started
Message-ID:
<address@hidden>
Content-Type: text/plain; charset="utf-8"
Cheers!
This is Pranav. I wish to contribute to nano editor as my project. Please
can anybody help me in getting started.
Thank You.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gnu.org/archive/html/nano-devel/attachments/20180923/bb47530b/attachment.html>
------------------------------
Message: 2
Date: Sun, 23 Sep 2018 08:47:50 +0200
From: Benno Schulenberg <address@hidden>
To: address@hidden
Subject: Re: [Nano-devel] Help Getting Started
Message-ID: <address@hidden>
Content-Type: text/plain; charset="utf-8"
Hello Pranav,
(Please don't send HTML mail. Send only plain text.)
Op 23-09-18 om 07:43 schreef Pranav Joglekar:
> This is Pranav. I wish to contribute to nano editor as my project. Please can
> anybody help me in getting started.
What can you do? How many lines of code have you written in C?
Can you handle gdb? What do you need to know to get started?
If you wish, you could start with trying to fix this bug:
https://savannah.gnu.org/bugs/?54712
It shouldn't be hard -- somehow something goes wrong in the
parsing routine. So you should be hunting through src/rcfile.c.
Benno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.gnu.org/archive/html/nano-devel/attachments/20180923/4d85b37b/attachment.pgp>
------------------------------
Message: 3
Date: Sun, 23 Sep 2018 01:37:35 -0600
From: Brand Huntsman <address@hidden>
To: address@hidden
Subject: Re: [Nano-devel] Help Getting Started
Message-ID: <address@hidden>
Content-Type: text/plain; charset=US-ASCII
On Sun, 23 Sep 2018 08:47:50 +0200
Benno Schulenberg <address@hidden> wrote:
> If you wish, you could start with trying to fix this bug:
> https://savannah.gnu.org/bugs/?54712
>
> It shouldn't be hard -- somehow something goes wrong in the
> parsing routine. So you should be hunting through src/rcfile.c.
The string can be written to stderr from implant() in winio.c, so more like an issue with put_back().
------------------------------
Message: 4
Date: Sun, 23 Sep 2018 11:52:17 +0200
From: Benno Schulenberg <address@hidden>
To: address@hidden
Subject: Re: [Nano-devel] Help Getting Started
Message-ID: <address@hidden>
Content-Type: text/plain; charset="utf-8"
Op 23-09-18 om 09:37 schreef Brand Huntsman:
> On Sun, 23 Sep 2018 08:47:50 +0200 Benno Schulenberg <address@hidden>
> wrote:
>> If you wish, you could start with trying to fix this bug:
>> https://savannah.gnu.org/bugs/?54712
>>
>> It shouldn't be hard -- somehow something goes wrong in the parsing routine.
>> So you should be hunting through src/rcfile.c.
>
> The string can be written to stderr from implant() in winio.c, so more like an
> issue with put_back().
Thanks for the hint. The problem is in the call of put_back().
Bug has been fixed locally. Now let's see if Pranav can find
the problem. (If he does not respond within two days, I'll
push the fix.)
Benno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.gnu.org/archive/html/nano-devel/attachments/20180923/cbe09f64/attachment.pgp>
------------------------------
Message: 5
Date: Sun, 23 Sep 2018 16:27:03 +0200
From: Benno Schulenberg <address@hidden>
To: address@hidden
Subject: [Nano-devel] [PATCH] bindings: make the linter separately
accessible, through M-B by default
Message-ID: <address@hidden>
This allows running the speller (default binding: ^T) also on files for
which a linter has been defined.
This fulfills https://savannah.gnu.org/bugs/?54711.
Requested-by: Mike Frysinger <address@hidden>
---
src/global.c | 26 ++------------------------
src/proto.h | 4 ----
src/winio.c | 7 -------
3 files changed, 2 insertions(+), 35 deletions(-)
diff --git a/src/global.c b/src/global.c
index 6cbf700f..72a3de51 100644
--- a/src/global.c
+++ b/src/global.c
@@ -1114,11 +1114,9 @@ void shortcut_init(void)
#ifdef ENABLE_SPELLER
add_to_sclist(MMAIN, "^T", 0, do_spell, 0);
add_to_sclist(MMAIN, "F12", 0, do_spell, 0);
-#else
-#ifdef ENABLE_COLOR
- add_to_sclist(MMAIN, "^T", 0, do_linter, 0);
- add_to_sclist(MMAIN, "F12", 0, do_linter, 0);
#endif
+#ifdef ENABLE_COLOR
+ add_to_sclist(MMAIN, "M-B", 0, do_linter, 0);
#endif
add_to_sclist(MMAIN, "^C", 0, do_cursorpos_void, 0);
add_to_sclist(MMAIN, "F11", 0, do_cursorpos_void, 0);
@@ -1358,26 +1356,6 @@ void shortcut_init(void)
#endif
}
-#if defined(ENABLE_COLOR) && defined(ENABLE_SPELLER)
-/* Assign one function's shortcuts to another function. */
-void replace_scs_for(void (*oldfunc)(void), void (*newfunc)(void))
-{
- for (sc *s = sclist; s != NULL; s = s->next)
- if (s->func == oldfunc)
- s->func = newfunc;
-}
-
-void set_linter_shortcut(void)
-{
- replace_scs_for(do_spell, do_linter);
-}
-
-void set_speller_shortcut(void)
-{
- replace_scs_for(do_linter, do_spell);
-}
-#endif /* ENABLE_COLOR && ENABLE_SPELLER */
-
const subnfunc *sctofunc(const sc *s)
{
subnfunc *f = allfuncs;
diff --git a/src/proto.h b/src/proto.h
index 71ef8eab..4c16b2ca 100644
--- a/src/proto.h
+++ b/src/proto.h
@@ -323,10 +323,6 @@ int keycode_from_string(const char *keystring);
void assign_keyinfo(sc *s, const char *keystring, const int keycode);
void print_sclist(void);
void shortcut_init(void);
-#ifdef ENABLE_COLOR
-void set_linter_shortcut(void);
-void set_speller_shortcut(void);
-#endif
const subnfunc *sctofunc(const sc *s);
const char *flagtostr(int flag);
#ifdef ENABLE_NANORC
diff --git a/src/winio.c b/src/winio.c
index 9de1247d..700b412c 100644
--- a/src/winio.c
+++ b/src/winio.c
@@ -3335,13 +3335,6 @@ void total_refresh(void)
* portion of the window. */
void display_main_list(void)
{
-#if defined(ENABLE_COLOR) && defined(ENABLE_SPELLER)
- if (openfile->syntax && openfile->syntax->linter)
- set_linter_shortcut();
- else
- set_speller_shortcut();
-#endif
-
bottombars(MMAIN);
}
--
2.17.1
------------------------------
Subject: Digest Footer
_______________________________________________
Nano-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/nano-devel
------------------------------
End of Nano-devel Digest, Vol 175, Issue 26
*******************************************
| [Prev in Thread] | Current Thread | [Next in Thread] |