[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] bright colors without bold

From: Brand Huntsman
Subject: Re: [Nano-devel] [PATCH] bright colors without bold
Date: Mon, 29 Jan 2018 18:48:38 -0700

On Sun, 28 Jan 2018 12:04:40 +0100
Benno Schulenberg <address@hidden> wrote:

> Hrm...  So the idea is to support "bright" only as a prefix of the
> color name (which makes sense, because it actually changes the color)
> and "bold" only as an attribute?  Okay.  But then the meaning of the
> "bright" prefix has to change to mean only bright and stop implying
> bold on terminal emulators.  That this changes the effect of the
> included nanorcs, that is what I want.  And that it changes also the
> effect of externally maintained nanorcs, that can't be helped.

Attached patch changes bright to only mean bright. The bold attribute will 
still brighten named colors, that is just how A_BOLD works.

The biggest problem is if an external syntax gets updated before nano. The old 
nano will see "bold,*", throw an error and ignore the regex. With the 
brightisnotbold toggle, external syntaxes could wait a year before switching to 
bold attribute and continue to work with both old and new nano. At some point, 
bright could be converted to new behavior and brightisnotbold could be ignored 
for a year before removing it.

> If people want the old look back:
>  sed -i 's/bright/bold,bright/' *.nanorc

(cd syntax ; sed -i 's/color bright/color bold,/' *.nanorc)

That command will convert the syntax files, default and external. 
"bold,brightred" is not valid, you use "bold,red" for bold&bright or 
"brightred" for just bright red.

Attachment: 0001-get-number-of-terminal-colors.patch
Description: Text Data

Attachment: 0002-attributes-and-bright-prefix-change.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]