Re: [Nano-devel] set the terminal emulator's titlebar

[Mike Frysinger]

On 28 Jan 2018 11:47, Benno Schulenberg wrote:
> Op 27-01-18 om 19:54 schreef Mike Frysinger:
> > On 27 Jan 2018 02:59, Brand Huntsman wrote:
> >> New patch uses the same path string displayed on nano's titlebar and only
> >> sends the titlebar sequence if DISPLAY is set.
> > 
> > i don't think that's correct.  that knob in general looks like a bad idea.
> 
> That knob exists so that nano can make the <Shift+Arrow> and <Ctrl+Arrow>
> combinations work when running on a Linux console.  That this breaks down
> when running nano remotely, can't be helped.  At least, I don't know how.

i don't know what scenario you're describing.  nano isn't an X related program
(and DISPLAY isn't set under Wayland so you've already lost there), so i don't
see why it's trying to check X things.  nano, as a program that runs inside of
a terminal emulator, should be using terminal emulator tools to handle things.
if you can't find relevant details in terminfo/ncurses, then you can use the
poor man's $TERM variable and compare it to "linux".

alternatively, if a terminal is known to not report keypresses according to
"the standard" (which i'm defining as either classic DEC specs ala vt100.net
or things xterm invented), then don't bother supporting them.

but i'm just talking in generalities.  the commit that added this check in
the first place doesn't have a reference to a bug/user report, and is a bit
light on details as to what it's trying to fix.
http://git.savannah.gnu.org/cgit/nano.git/commit/?h=290d278f684f11448307a2871f42af67f982be46

> Should we drop support for the ninety percent of the cases where nano is
> run locally on a console just because the solution is not perfect?

i don't know how you're creating those numbers.  are you saying that 90%
of the time, people are running nano on a Linux VT ?  that sounds pretty
unlikely.  seems way more likely the majority of users are either running
it directly under X (via some terminal emulator) or indirectly via ssh.
-mike

signature.asc
Description: Digital signature