[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] syntax variables

From: Brand Huntsman
Subject: Re: [Nano-devel] [PATCH] syntax variables
Date: Wed, 17 Jan 2018 16:20:28 -0700

On Wed, 17 Jan 2018 13:55:53 -0500
Mike Frysinger <address@hidden> wrote:

> you both modify str and return it directly.  this API is a bit funky.
> seems like str should be const and you should return the result.

Where does this happen?

I null-terminate parts of str in interpolate_string() but then revert
the change if the placeholder is invalid. If the string contains no valid
placeholders, it will be identical to the original. This is how all
rcfile code currently works, look at parse_next_word(), it does the
same null-termination to the same string modified by interpolate_string().

reply via email to

[Prev in Thread] Current Thread [Next in Thread]