[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] input: allow using <Tab> and <Shift+Tab> to...

From: David Ramsey
Subject: Re: [Nano-devel] [PATCH] input: allow using <Tab> and <Shift+Tab> to...
Date: Tue, 12 Dec 2017 15:02:10 -0600

Benno Schulenberg:
> None of them were, but the back tab is pretty special: nano didn't
> make use of it until now.  :)

Indeed :)

> Anyway, the <Tab> changes have been pushed, so you can make any needed
> additional changes now.

Thank you.  See below.

> I don't see why a SHIFT_TAB value would be needed.  We only ask
> ncurses for a keycode when /usr/include/ncurses.h does not define a
> KEY_ symbol for the corresponding key.

After looking at the code some more, you're right in that reading kcbt
is unnecessary.  However, if KEY_BTAB isn't defined, but the backtab
escape sequence is supported (as it is under Slang, at least), the
fake SHIFT_TAB key is still needed as a placeholder.

So here's an updated version of the patch: I've resynced it with
current git (e2843ed) and made it a proper git patch, it no longer
unnecessarily reads kcbt, and I've updated the comment describing
which systems treat Esc [ Z as backtab is updated using the info here
as best I can:

(Incidentally, Eterm doesn't support backtab at all, and the above
source says iTerm supports it, but I have no idea whether iTerm2
supports it.  It's ANSI, in any case.)

Attachment: 0001-input-support-backtab-when-Slang-and-or-rebindkeypad.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]