[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] Some improvements

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] Some improvements
Date: Thu, 7 Dec 2017 21:22:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0

Op 07-12-17 om 10:48 schreef Liu Hao:
These are patches discussed earlier today, now reshuffled and signed
off. Please review

About all patches: your subject lines are far too long.  Look at the
git repo.  The first line of a commit message is at most 74 characters
long.  If you need more text, use a second, separate paragraph.

About the second patch: why does coloring of preprocessor directives
now require two color statements?  And statements that are nearly
identical at that.  Why can't it be done with one of them?

Sixth patch: brightred on yellow is in the same class as grey on yellow.
It's just a change, not an improvement.  I will accept brightwhite, but
not anything else.

Seventh patch: there is no need for a boolean 'can_unindent' to achieve
the desired behavior.  And there is no need for feedback when there is
nothing to unindent -- there is no feedback either when it's impossible
to go further up or down or home.  See attached patch for the minimum
amount of changes required to get the new behavior.  (In a second patch
you could rewrite the length_of_white() routine, but then it has to
become shorter than what you have now.)


Attachment: minimum-changes-to-achieve-other-unindenting.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]