Re: [Nano-devel] implementing macro recording and playback

[Benno Schulenberg]

Op 10-10-2017 om 00:10 schreef Marco Diego Aurélio Mesquita:
> The attached should address the listed issues.

Thanks.  I have further edited the patch.  First of all: I have
changed my mind about the default key bindings.  The Shift+Alt
keystrokes were too hard: it would not invite the use of the
feature.  Of course frequent users will probably make their
own bindings, but also the default bindings should be somewhat
usable.

So I have decided that M-' should start and stop the recording
of a macro -- mnemonic: a quote before and after the stuff that
should be recorded.  And M-; runs a macro -- mnemonic: another
subphrase.  Comments welcome.

I've also excluded macro recording and playback from the tiny
version, and have addressed the one issue that you skipped:
move the trimming of the macro buffer to record_macro().

Furthermore, the upcoming version of the patch removes the
runmacro keystroke from the macro buffer when this key is hit
during the recording of a macro.  Because otherwise it would
lead to a lockup (when the recording is finished and then run).

> There's one small
> problem: macro_buffer may be leaked, but I don't know where is the
> best place to deallocate it.

No need to deallocate the buffer.  It will be relinquished as
soon as nano exits.

> Please, consider applying.

Let's give it a few days of testing.  Please inspect the patch
and see if you are still okay with it.

Benno