[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] bug with positioning in non-softwrap mode after the ove

From: David Ramsey
Subject: Re: [Nano-devel] bug with positioning in non-softwrap mode after the overhaul
Date: Fri, 17 Mar 2017 09:52:08 -0500

On Fri, Mar 17, 2017 at 7:39 AM, Benno Schulenberg
<address@hidden> wrote:

> If you can fix the bug, please only send the patch that was changed.
> Or if you prefer to fix the bug on top of the current patch set, that
> is fine too.

Fixing it on top of the current patch set is easier; I'll do that.

> I'm pretty sure that the mistake is in patch 0002. You can probably
> elide rows_left, and then check for rows_from_tail being smaller than
> editwinrows/2 instead of being nonzero.

Eliding rows_left will make it harder to debug, as gdb can trace a
variable more easily than a function call, so for right now I've just
fixed the rows_from_tail check.

The two attached patches are on top of the current patch set.  The first
one fixes the issue you brought up.  The second fixes an issue I
noticed: do_up() and do_down() unnecessarily call xplustabs() twice on
the same spot in softwrap mode, once to set was_column, and once to
calculate leftedge.  I made leftedge use was_column to save processing

Attachment: 0001-tweaks-fix-line-number-range-check-when-seeing-if-we.patch
Description: Text Data

Attachment: 0002-tweaks-avoid-calling-xplustabs-twice-on-the-same-loc.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]