nano-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] Nano with Line Numbering


From: Faissal Bensefia
Subject: Re: [Nano-devel] Nano with Line Numbering
Date: Sun, 09 Oct 2016 17:54:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/10/16 16:58, Benno Schulenberg wrote:
> 
> On Sun, Oct 9, 2016, at 17:24, Faissal Bensefia wrote:
>> I've attached the new diff, compute_maxrows() was miscalculating how
>> many lines we had, subtracting 1 from the margin seems to correct the
>> issue without affecting situations where the line numbers are disabled.
> 
> First, this can't be right, because it will see each screen line
> as consisting of COLS-1 characters for computing how many
> softwrapped lines fit on it (when margin is zero).
> 
> Second, it doesn't fix the issue.  When running 'stty rows 20 &&
> stty cols 70 && src/nano --ignore --softwrap +999 README --line'
> the cursor is still after "hand" instead of on the final line.
> 
> (Also, please don't top-post.)
> 
> Benno
> 

Ah I see, sorry I misread what you said. This diff should fix it, it was
an issue with scrolling not taking into account the margin.

~Faissal Bensefia

Attachment: 0001-Added-line-numbering.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]