[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] several ASCII characters from 64 to 127 cannot

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] several ASCII characters from 64 to 127 cannot be rebound but are accepted without protest
Date: Sun, 18 Sep 2016 21:49:07 +0200

On Sun, Sep 18, 2016, at 14:45, Rishabh Dave wrote:
> Following is link to the bug -

Savannah is down at the moment.  I can't see the bug report.

> Attached patch disallows rebinding of ^@, ^[, ^{, ^|, ^}, ^~, ^`


> Some invalid keys are
> coloured green (^{, ^}, ^|), so it recolours them in red.

Ehm... no, you don't recolor them, you just prevent them from
being colored green.  Which means they stay red.

There seems to be something wrong in the unbind line: "0-9" etcetera
now occurs three times, but it should be two, I think?

> Also, M-@, M-~ and M-` work fine but they are coloured red. I have
> attached another patch for colouring these meta combinations to green.

Do that in the same patch: you take the trouble of pulling ^something
and M-something apart, you may then as well make each of them cover
exactly those cases which it should cover.  For example: ^; and ^<
should stay red (and many more).

> By the way, should I trim too long subject lines (like this one)? Or
> completeness is preferred?

I don't care.  This is email.  But when you write [PATCH], a description
of the /patch/ is expected, not a description of the bug that it fixes.


-- - Email service worth paying for. Try it for free

reply via email to

[Prev in Thread] Current Thread [Next in Thread]