[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations

From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] add rebinding for Ctrl+Arrow-keys combinations
Date: Mon, 5 Sep 2016 10:46:16 +0530

On Mon, Sep 5, 2016 at 12:40 AM, Benno Schulenberg
<address@hidden> wrote:
> On Sun, Sep 4, 2016, at 18:29, Rishabh Dave wrote:
>> Okay, patch is attached. Please tell me if it is fine. If so, I will
>> attach it to the bug too.
> Thanks.  Patch looks better.  Just one little thing.  I will change
>   if (!strcasecmp(keystring, "^Up"))
> to
>   if (strcasecmp(keystring, "^Up") == 0)
> to follow the if that comes before it, and because I find the first form
> confusing.  I know: the current code uses that form in many places, but
> not everywhere.

Shall I attach the patch I sent to the bug? And this minor change
included or un-included?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]