[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH 2/2] use futimens() if available, instead of uti

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH 2/2] use futimens() if available, instead of utime()
Date: Thu, 21 Jul 2016 12:52:54 +0200

Hi Kamil,

On Wed, Jul 20, 2016, at 16:54, Kamil Dudka wrote:
> Still the code of nano needs to be changed to use file 
> descriptors instead of file names if possible.  I will take care of rebasing 
> (and reducing) the patch once the gnulib patch set is pushed.

Okay.  Thanks.

> > > + /* copy_file() closed the files, make sure 'f' is not used any more. */
> > > + f = NULL;
> IIRC, it does not fix any existing bug.  It was just meant as defensive
> coding to prevent possible bugs while changing the code in the future.

Okay -- glad it isn't the cure for some hidden bug.

I am more a walk-along-the-edge type, but if you want to provide this
defensive line (and maybe others) as a separate patch, I'll accept.


-- - Same, same, but different...

reply via email to

[Prev in Thread] Current Thread [Next in Thread]