[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] streamlining a bit of syntax coloring

From: Benno Schulenberg
Subject: Re: [Nano-devel] streamlining a bit of syntax coloring
Date: Sun, 17 Jul 2016 13:25:29 +0200

On Sat, Jul 16, 2016, at 16:49, Rishabh Dave wrote:
> Structure colortype has new element called attributes

Good.  But don't just add it at the end; put it at a meaningful
place: after the pair number, because attributes is an amalgam
of pair number and brightness, the two preceding elements, and
make it clear in the comment that it is such an amalgam.

> and it is initialized as soon as pairnum is
> initialized (change in color.c)

Okay.  Functionality is good.  When you've fixed the above,
send a signed-off patch -- which would be best to do always,
because the commit message is an essential part of a change.


-- - Access all of your messages and folders
                          wherever you are

reply via email to

[Prev in Thread] Current Thread [Next in Thread]