[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] browser: repalce newpath by path and present_pa

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] browser: repalce newpath by path and present_path
Date: Thu, 07 Jul 2016 21:31:44 +0200

> On Tue, Jul 5, 2016 at 11:28 PM, Rishabh Dave <address@hidden> wrote:
> > Attached patch replaces all occurrences of newpath in do_browser().

Sorry.  Have had no time.  Busy.

But from a quick look:

-               free(newpath);
-               newpath = NULL;
+               free(path);
+               path = NULL;

Are you sure you want to make path null?  Don't you want to
restore it from present_path?  Have you tested this route
through the code?  You know: --operatingdir, ^R ^T, try to
go outside, ^L.


-- - Choose from over 50 domains or use your own

reply via email to

[Prev in Thread] Current Thread [Next in Thread]