[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] bug #48305: allow any kind of separator in "Go

From: Rishabh Dave
Subject: Re: [Nano-devel] [PATCH] bug #48305: allow any kind of separator in "Go To Line"
Date: Mon, 4 Jul 2016 19:36:26 +0530

On Mon, Jul 4, 2016 at 6:00 PM, Benno Schulenberg
<address@hidden> wrote:
> Patch is not simple enough.  You don't need the variable 'accept'.
> When you've got rid of it, sign off your patch.

Yes. Replaced 'accept' where it was used by the literal itself. Also,
replaced comma by separator. Patch is attached.

>> > But it should be unnecessary to use Alt+P.  When you look at a
>> > .patch or .diff file with nano, trailing whitespace should be
>> > very visible: green blocks at the ends of lines.
>> I edited rc-file with the help of manual, now it is working well.
> ??  You shouldn't need to edit ~/.nanorc to get syntax coloring
> for .patch files.

I too felt so because the syntax colouring was working well before. I
don't remember what version of nano I had then.

>  But if your /etc/nanorc file doesn't do it, then
> do 'include /usr/share/nano/patch.nanorc' in your ~/.nanorc.

Exactly what I did.

>> There are some green blocks in patch by default - source file doesn't
>> have them. So, they are not be bothered with, I assume; must be
>> introduced by git diff program.
> ??  Nano's patch syntax does not show green blocks where there
> is no trailing whitespace.

Not trailing whitespace but it shows green block in first column on
lines separating two blocks of code (like attached patch has one among
many at line 24). They are introduced by git diff program as first
column contains a '+' or '-' sign there.

Attachment: 0001-utils-allow-more-separators-at-Go-To-Line.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]