[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] [PATCH] browser: remove opendir() for KEY_WINCH

From: Benno Schulenberg
Subject: Re: [Nano-devel] [PATCH] browser: remove opendir() for KEY_WINCH
Date: Sat, 02 Jul 2016 13:05:20 +0200

On Fri, Jul 1, 2016, at 16:27, Rishabh Dave wrote:
> On Thu, Jun 30, 2016 at 1:08 AM, Benno Schulenberg
> <address@hidden> wrote:
> > Sorry, I haven't tried your patch, as it is the wrong approach,
> > in my opinion.
> Due to duplicated statements, to be precise?

Yes.  When you have to put the same things in several places,
put them somewhere else so you need to put them just once.

> > Now see if you can break my patches.
> > That is: find a case where they go wrong.
> > (I don't think there is, so if you find one, you will surprise me.)
> As far as I could test (which is not very far), I couldn't break it.

Thanks for testing.  Already pushed, in d9aad92 and after.

Next step: see if you can get rid of the first opendir() without
adding or deleting or renaming any variable, and in the bargain
improving the response when typing ^R noread ^T (where 'noread'
is a directory without any read access).


-- - Access all of your messages and folders
                          wherever you are

reply via email to

[Prev in Thread] Current Thread [Next in Thread]