Re: [Nano-devel] [PATCH] build: prevent -Werror from interfering with configure checks

[Benno Schulenberg]

On Wed, Jun 22, 2016, at 12:38, Mike Frysinger wrote:
> On 22 Jun 2016 11:15, Benno Schulenberg wrote:
> > Hm.  How then should I go about when I want anything that is
> > compiled on this box to be compiled with -Werror?  If I can't
> > add it to CFLAGS, where should I put it?
> 
> you can add a --enable-werror configure flag that'll take care of
> appending it at the end of the script

Where does --enable-werror come from?  My configures don't have it:
  configure: WARNING: unrecognized options: --enable-werror

$ ./configure --help | grep error

Blank.

> also, your patch here made this question moot too: you just turned
> off warnings altogether.  so even if you added -Werror, the end
> result would be for it to be negated.

Ah.  Hadn't even noticed that.  Can be avoided with:

+was_CFLAGS="$CFLAGS"
+CFLAGS="$CFLAGS -w"
 
 And at the end (of configure.ac):

+CFLAGS="$was_CFLAGS"


> https://lists.gnu.org/archive/html/autoconf/2010-03/msg00015.html
> 
> User: what to do best here?
> autotool guy: Not using -Werror
> autotool guy: That's been the standard advice for years now.

Okay.  Let's drop it.

Benno

-- 
http://www.fastmail.com - Does exactly what it says on the tin