Re: [Nano-devel] [PATCH] build: prevent -Werror from interfering with configure checks

[Mike Frysinger]

On 22 Jun 2016 11:15, Benno Schulenberg wrote:
> On Tue, Jun 21, 2016, at 21:03, Mike Frysinger wrote:
> > NAK: the user is doing it wrong,
> 
> Hm.  How then should I go about when I want anything that is
> compiled on this box to be compiled with -Werror?  If I can't
> add it to CFLAGS, where should I put it?

you can add a --enable-werror configure flag that'll take care of
appending it at the end of the script

also, your patch here made this question moot too: you just turned
off warnings altogether.  so even if you added -Werror, the end
result would be for it to be negated.

> > and we shouldn't be trying to "fix"
> > the build for them.  their report applies to pretty much every autoconf
> > project out there, and even the autotools guys reject this setup.
> 
> I can find that projects should not add -Werror to their build scripts
> (https://lists.gnu.org/archive/html/bug-autoconf/2016-05/msg00001.html),
> but I can't find that users shouldn't be using -Werror in their CFLAGS,
> nor that projects should not try to disarm -Werror during ./configure.
> Do you have a link for that?

https://lists.gnu.org/archive/html/autoconf/2010-03/msg00015.html

User: what to do best here?
autotool guy: Not using -Werror
autotool guy: That's been the standard advice for years now.
-mike

signature.asc
Description: Digital signature