Re: [Nano-devel] [PATCH] browser: awkward behaviour when trying to open inaccessible directory using goto prompt

[Rishabh Dave]

On Tue, Jun 21, 2016 at 8:52 PM, Benno Schulenberg
<address@hidden> wrote:
>
> Yes.  I was waiting for you to submit a patch doing that.  :)

I knew. Thank you!  :)

> Patch looks good.  At first I thought it would be nice to "select"
> (to highlight) the inaccessible directory, but that is difficult,
> and is not generally possible because it might be outside of the
> current dir.  So, let it be as it is -- these are highly unlikely
> cases after all.

Okay... I've made a small attempt to do that. It worked. Since my work
normally has side effects, I also read the code (relevant to variable
selected) to check. Patch (after committing on a new branch) is
attached. It is up to you to keep it or not.

>> I have added a comment and tryed to keep it short but it, to me, looks
>> imprecise; doesn't capture the fact that newpath could be null.
>
> Could it be NULL?  How?  Because if so, that would be bad: it would
> crash on doing "if (newpath[0] != '/')".
>

I've made mistake, I am sorry; it couldn't be NULL. Actually I was
worried about free(newpath) (and I wrongly took result of free() to be
NULL, which I knew is not the case). So... comment is fine.


Should I reply over the bug-tracker too, or that's okay?

select-if-in-cwd.patch
Description: Text Data