[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] browser: merging opendir() in to one
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] browser: merging opendir() in to one |
Date: |
Sat, 21 May 2016 21:38:25 +0200 |
On Sat, May 21, 2016, at 13:33, Rishabh Dave wrote:
> Did just the first step: shifting, both, opendir() from
> do_browser_from() and closedir() from browser_init() to do_browser().
Again, you changed the behavior. But to be fair: just in theory,
because it is not visible. But it will be visible if after the
beep() you would add statusbar("woosh"); napms(200); -- then run:
'mkdir woosh && cd woosh && ../src/nano' and in another terminal:
'rmdir woosh'. Then type: ^R ^T. Woosh. It wouldn't have shown
the browser menu before your patch.
Anyway, I find it uninformative that ^T only beeps when the working
directory has disappeared, so I am going to add an error message
for that. Then the path==NULL case will disappear.
Bleh... We have a memory leak there, in do_browse_from(). And in
get_full_path() too. Both when getcwd() returns NULL...
Okay, those are fixed now.
Try again. Make your patch again, with a signed-off line, and
a good commit message.
Benno
--
http://www.fastmail.com - Or how I learned to stop worrying and
love email again
- [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/14
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/15
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/18
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/19
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/21
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one,
Benno Schulenberg <=
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/22
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/22
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Rishabh Dave, 2016/05/24
- Re: [Nano-devel] [PATCH] browser: merging opendir() in to one, Benno Schulenberg, 2016/05/25