Re: [Nano-devel] disable a time-consuming multiline regex?

[Benno Schulenberg]

On Wed, Dec 30, 2015, at 20:32, address@hidden wrote:
> [...] I also added additional hash tags for th comments,

Please don't mix cosmetic changes with functional ones.

> as that
> is what most people, and nanorc highlighting use for comments.

No they don't.  The gentoo one does, none of the others do.

> If you find any of the regex's difficult, just ask, or use grep on some
> source files.

Stop being so condescending.

More importantly: don't make me ask for explanations.  You provide
a patch, on you is the burden to explain why it is needed, why the
changes improve things, what problems they solve.

> -color brightyellow "<[^=     ]*>" ""(\\.|[^"])*""
> +color brightwhite ""[^"\\]*""

Why is ""[^"\\]*"" better than the two regexes on the line before?

> +## CPP directives. They need to go after strings because the can include 
> strings.
> +color brightwhite,cyan 
> "^[[:blank:]]*#[[:blank:]]*(define|(un|ifn?)def|endif|el(if|se)|if|warning|error|pragma)[[:graph:]]*"

That you changed [[:space:]] to [[:blank:]] is good.  But why did you add
[[:graph:]]* at the end?  What is it supposed to cover?  And why does the
patch not remove the earlier line that covers preprocessor directives?

Benno


-- 
http://www.fastmail.com - Same, same, but different...