[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] disable a time-consuming multiline regex?

From: Mike Frysinger
Subject: Re: [Nano-devel] disable a time-consuming multiline regex?
Date: Thu, 31 Dec 2015 12:29:58 -0500

On 30 Dec 2015 14:32, address@hidden wrote:
> -# GCC builtins.
> +## GCC builtins.

these changes are incorrect.  we want one #.

> -color brightyellow "<[^=     ]*>" ""(\\.|[^"])*""
> +color brightwhite ""[^"\\]*""

so basically you change strings from yellow to white.  i don't think
we should thrash on purely style preferences.

> +## CPP directives. They need to go after strings because the can include 
> strings.
> +color brightwhite,cyan 
> "^[[:blank:]]*#[[:blank:]]*(define|(un|ifn?)def|endif|el(if|se)|if|warning|error|pragma)[[:graph:]]*"
> +## This highlights the includes.
> +color brightwhite,cyan 
> "[[:blank:]]*#[[:blank:]]*include(_next)?[[:blank:]]*(<[^[:blank:]="\\]*>|"[^[:blank:]="\\]*")"

i dislike these both, a lot.  imo we should generally avoid doing
background colors except for when we want to grab the user's attention
by something "bad" or "notable".  cpp directives are not that imo.
just load up something like /usr/include/elf.h to see.

i also don't think they add anything useful -- we already highlight cpp

> +## Highlighting FIXME.
> +color brightyellow,yellow "/?\*?/?FIXME(!|\?|\.)*\*?/?"
> +
> +## Reminders.
>  color ,yellow "(FIXME|TODO|XXX)"

i don't see what your new change here does that is useful over
the existing marker we do for FIXME/TODO/XXX.

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]