[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Nano-devel] compensating for changed length

From: Mark Majeres
Subject: Re: [Nano-devel] compensating for changed length
Date: Fri, 27 Mar 2015 07:02:41 -0700

On 3/27/15, Benno Schulenberg <address@hidden> wrote:
> On Thu, Mar 26, 2015, at 21:35, Benno Schulenberg wrote:
>> On Wed, Mar 25, 2015, at 18:19, Mark Majeres wrote:
>> > Attached is a patch to adjust the selection after a spell check.
>> Thanks.  Testing...
> It works well.
> But the assignment to openfile->current_x is unneeded, I think:
> between there and the call to goto_line_posx (where it gets set
> anyway) nothing uses it.  No?
> So I've removed that assignment, added a comment, normalized
> the whitespace, and put the declaration of the bool a line higher.
> Tweaked patch is attached.  Can it get your stamp of approval,
> Mark?
The only reason I can see to leave the call is for consideration and
clarity to other coders.
The assignment of openfile->current_x  is a step that needs to occur
in order to correctly re-establish the marked region.  Either way, it
probably compiles into the same asm.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]