Re: [Nano-devel] The undo feature

[Chris Allegretta]

On 10/27/14, Erik Lundin <address@hidden> wrote:
>
>> Please look at do_wrap(), it shows how to use sub-undo's by only using
>> the existing undo structure.   Try to do all of the work in "tabs to
>> spaces" by using the do_delete() functions and wrapping the addition
>> of spaces with add_undo(ADD) and update_undo(ADD)
>>
>>
>> --Mark Majeres
>
> I've looked through the do_wrap() function and personally i think the
> whole undo function needs a remake. Retrofitting new code to fit the old
> code that never was designed to work that way seems wrong. For example,
> implementing a "undo step" function will be unnecessarily complicated
> with the current code.
>
> But i understand that there's a lot of politics involved. Is Chris still
> the lead designer? What's your view on this Chris?

My view is that undo works very well now; it worked awfully before and
a lot of the reasons are my fault.  As for what it sounds like you're
proposing, you can rework everything if that's easier, that's your
call. However It'll take longer to get accepted as 'generally working'
and someone (probably both Benno and myself) will need to do a lot
more reading and testing of it before it gets accepted.

Replacing newlines could take eons the way the code is constructed
now.  If there's groundwork that can be laid to eventually allow that,
that's great, but I'm a bit pessimistic that we could ever shoehorn
that into the editor without a complete rewrite, so I'd argue for
keeping the undo changes scoped to what you're really trying to
accomplish.