[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] [PATCH] clean up autoconf with/enable macros
From: |
Benno Schulenberg |
Subject: |
Re: [Nano-devel] [PATCH] clean up autoconf with/enable macros |
Date: |
Mon, 24 Mar 2014 14:54:42 +0100 |
On Sun, Mar 23, 2014, at 23:03, Mike Frysinger wrote:
> This cleans up most, but not all, of the --with/--enable flags:
> - Use AS_HELP_STRING instead of writing the text ourselves
> - Use the normal enable_xxx var AC_ARG_ENABLE creates for us
> - Delete duplicate checks in a few places (due to previous cleanup)
> - Unwrap some macros/var assignments
> - Delete trailing whitespace
> - Delete old --enable-all flag
> - Fix quoting on a lot of vars that come from the user
> - Use AC_MSG_* helpers instead of raw `echo`
> ---
> configure.ac | 193
> ++++++++++++++++++++++++++---------------------------------
> 1 file changed, 84 insertions(+), 109 deletions(-)
The ncurses and libmagic patches have been applied too. Thanks.
On this big one I'd like to see some comments first.
Chris? Eitan? Kamil? ...
Regards,
Benno
--
http://www.fastmail.fm - Or how I learned to stop worrying and
love email again