[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Nano-devel] compile nano.
From: |
David Lawrence Ramsey |
Subject: |
Re: [Nano-devel] compile nano. |
Date: |
Mon, 27 May 2002 09:40:28 -0700 (PDT) |
David Benbennick wrote:
>I have been having irreproducible segfault problems lately
>too. I think sometimes the cause is that current_x is too
>large in do_backspace(), do_delete(), or do_char(). Then
>the third argument to memmove() is negative. But it is
>typecast to size_t, which is normally unsigned, so it
>becomes huge. One way to make nano a little safer would be
>to add checks for the third argument of memmove(). But
>that doesn't explain how current_x gets too big in the
>first place.
It's the lack of the sanity checks in do_down() and do_up();
sorry for that screwup. I don't know why current_x is
sometimes too large after the call to
actual_x[_from_start](), but you can fix the problem for now
by just putting the sanity checks back in; see
http://savannah.gnu.org/cgi-bin/viewcvs/nano/nano/move.c.diff?r1=1.27&r2=1.28&diff_format=h
for reference. (This is also fixed in my latest patch.)
_____________________________________________________________
Sluggy.Net: The Sluggy Freelance Community!
_____________________________________________________________
Promote your group and strengthen ties to your members with address@hidden by
Everyone.net http://www.everyone.net/?btn=tag
- Re: [Nano-devel] compile nano., (continued)
- Re: [Nano-devel] compile nano., Jordi Mallach, 2002/05/14
- [Nano-devel] compile nano., Petrov M.I., 2002/05/25
- Re: [Nano-devel] compile nano., Gareth Pearce, 2002/05/26
- Re: [Nano-devel] compile nano., Gareth Pearce, 2002/05/26
- Re: [Nano-devel] compile nano., David Lawrence Ramsey, 2002/05/26
- Re: [Nano-devel] compile nano.,
David Lawrence Ramsey <=