[myexperiment-hackers] [3237] branches/wf4ever/app/models/network.rb: Avoid null-membership when creating group

[noreply]

Revision

3237

Author

stain

Date

2012-12-06 12:35:37 +0000 (Thu, 06 Dec 2012)

Log Message

Avoid null-membership when creating group

Modified Paths

• branches/wf4ever/app/models/network.rb

Diff

Modified: branches/wf4ever/app/models/network.rb (3236 => 3237)

--- branches/wf4ever/app/models/network.rb	2012-12-06 12:35:31 UTC (rev 3236)
+++ branches/wf4ever/app/models/network.rb	2012-12-06 12:35:37 UTC (rev 3237)
@@ -230,9 +230,13 @@
   #  (as group owners do not have a membership)
   def update_administrators
     if user_id_changed?
-      Membership.find_by_user_id_and_network_id(user_id, id).try(:destroy) # delete membership of new owner
-      Membership.create(:user_id => user_id_was, :network_id => id,
-                        :administrator => true, :invited_by => User.find(user_id)).accept! # create membership for old owner
+      if (user_id)
+        Membership.find_by_user_id_and_network_id(user_id, id).try(:destroy) # delete membership of new owner
+      end  
+      if (user_id_was)
+        Membership.create(:user_id => user_id_was, :network_id => id,
+                          :administrator => true, :invited_by => User.find(user_id)).accept! # create membership for old owner
+      end
     end
   end