Re: [Monotone-devel] Contradiction in Makefile.am

[Richard Levitte]

In message <address@hidden> on Wed, 23 Feb 2011 10:16:49 +0100, Thomas Keller 
<address@hidden> said:

me> Am 23.02.2011 07:42, schrieb Richard Levitte:
me> > I just had a closer look at the NLS support in Makefile.am, and I'm
me> > finding this (dist-nls used to be dist-local until that one needed
me> > expanding):
me> > 
me> > ...
me> > CLEAN_POFILES := $(ALL_GMOFILES) \
me> >            $(addprefix po/,$(addsuffix .merged.po, $(ALL_LINGUAS))) \
me> >            po/$(PACKAGE).pot
me> > ...
me> > dist-nls: $(ALL_GMOFILES)
me> >   cp $(ALL_GMOFILES) $(distdir)/po
me> > ...
me> > 
me> > 
me> > Now, I don't know about you, but to me, it seems contradictory to have
me> > the .gmo files be part of the distribution, but then have them wiped
me> > with 'make clean'.
me> > 
me> > So, how shall we have it?  What's the reason for .gmo files to be part
me> > of the source distribution?  Or, if they really should be (I'm sure
me> > there is a good justification), why are they part of things to be
me> > cleaned with 'make clean'???
me> 
me> For me it sounds wrong to have the gmo files compiled in the tarball,
me> but there might have been a good reason why this has been the case in
me> the past. If there are no strong objections I'm all for removing the gmo
me> files from dist.

Ah, looking for REBUILD_NLS in m4/mtn-gettext.m4 explains it, we
distribute it to help those who do not have gettext and similar tools
installed.

Ok, I can play with that, and it is reasonable (users shouldn't have
to deal with translations, possible fuzzies that appear suddenly and
make for confusing (perhaps even erroneous) messages and so on).  it
means that CLEAN_POFILES shouldn't contain $(ALL_GMOFILES), though.
That one needs to go into MAINTAINERCLEANFILES.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish